Supervisord fails to start Solr after Vagrant VM is provisioned

[hackdna]

Running 48d2422.

Steps to reproduce

$ git clone git@github.com:parklab/refinery-platform.git
$ cd refinery-platform
$ vagrant up

Observed results

Supervisord fails to start Solr because it has already been started by its installation script during provisioning:

(refinery-platform)vagrant@refinery:/vagrant/refinery$ supervisorctl status
celerybeat                       RUNNING   pid 9802, uptime 0:10:20
celerycam                        RUNNING   pid 9799, uptime 0:10:20
celeryd:worker1                  RUNNING   pid 9800, uptime 0:10:20
celeryd:worker2                  RUNNING   pid 9801, uptime 0:10:20
neo4j                            RUNNING   pid 9804, uptime 0:10:20
runserver                        RUNNING   pid 9803, uptime 0:10:20
solr                             FATAL     Exited too quickly (process log may have details)
(refinery-platform)vagrant@refinery:/vagrant/refinery$ supervisorctl tail solr

Port 8983 is already being used by another process (pid: 32140)
Please choose a different port using the -p option.

(refinery-platform)vagrant@refinery:/vagrant/refinery$ ps aux | grep solr
vagrant  10739  0.0  0.0  10460   932 pts/0    S+   14:39   0:00 grep --color=auto solr
vagrant  32140  0.6 10.2 1455548 157312 ?      Sl   14:24   0:05 java -server -Xss256k -Xms512m -Xmx512m -XX:NewRatio=3 -XX:SurvivorRatio=4 -XX:TargetSurvivorRatio=90 -XX:MaxTenuringThreshold=8 -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:ConcGCThreads=4 -XX:ParallelGCThreads=4 -XX:+CMSScavengeBeforeRemark -XX:PretenureSizeThreshold=64m -XX:+UseCMSInitiatingOccupancyOnly -XX:CMSInitiatingOccupancyFraction=50 -XX:CMSMaxAbortablePrecleanTime=6000 -XX:+CMSParallelRemarkEnabled -XX:+ParallelRefProcEnabled -XX:CMSFullGCsBeforeCompaction=1 -XX:CMSTriggerPermRatio=80 -verbose:gc -XX:+PrintHeapAtGC -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintGCTimeStamps -XX:+PrintTenuringDistribution -XX:+PrintGCApplicationStoppedTime -Xloggc:/vagrant/refinery/solr_app_data/logs/solr_gc.log -Djetty.port=8983 -DSTOP.PORT=7983 -DSTOP.KEY=solrrocks -Duser.timezone=UTC -Djetty.home=/opt/solr/server -Dsolr.solr.home=/vagrant/refinery/solr_app_data/data -Dsolr.install.dir=/opt/solr -Dlog4j.configuration=file:/vagrant/refinery/solr_app_data/log4j.properties -jar start.jar -XX:OnOutOfMemoryError=/opt/solr/bin/oom_solr.sh 8983 /vagrant/refinery/solr_app_data/logs --module=http

Expected results

Supervisord should be able to start Solr when the VM is provisioned. Alternatively, Solr should be removed from Supervisord control and started/stopped by an init script instead.

[flekschas]

Works for me with fb95d6e

[hackdna]

We should avoid introducing workarounds that add more code when there is a solution that requires less code. I'm going to move Solr management from supervisor to init.