-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabular metadata file upload form is not displayed correctly #790
Comments
Fixed as of 4c7f34b. However, the file is not displayed in the table after it is selected the following error message is logged in the browser console:
|
One more issue: initial column width used to be set automatically according to the column header length to make them more readable. Now all the columns are equally narrow and headers are unreadable unless manually resized. The code that performs the calculation is here. |
Thanks for bringing this up. It looks like styling is missing from buttons and drop-downs in Firefox too. |
From the bootstrap components website http://getbootstrap.com/components/ : Avoid using select elements here as they cannot be fully styled in WebKit browsers. Avoid using textarea elements here as their rows attribute will not be respected in some cases. |
@hackdna This is the default bootstrap3 styling. Chrome has it's own styling which is being applied. |
@flekschas @hackdna @ngehlenborg I fixed the column situation. If you agree, I'd like to close this issue and write a separate issue for tackling uniform styling between browsers and updating styling to the new style guide http://uspto.github.io/designpatterns/1.x/docs/patterns/fileUpload.html |
I agree with that plan. |
Looks good. |
The form should not appear before a file is selected. Running commit 6eec78c.
The text was updated successfully, but these errors were encountered: