Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabular metadata file upload form is not displayed correctly #790

Closed
hackdna opened this issue Nov 30, 2015 · 10 comments
Closed

Tabular metadata file upload form is not displayed correctly #790

hackdna opened this issue Nov 30, 2015 · 10 comments

Comments

@hackdna
Copy link
Member

hackdna commented Nov 30, 2015

The form should not appear before a file is selected. Running commit 6eec78c.
image

@hackdna hackdna added this to the Next milestone Nov 30, 2015
@jkmarx jkmarx self-assigned this Nov 30, 2015
@jkmarx jkmarx modified the milestones: Kingston, Next Nov 30, 2015
@hackdna
Copy link
Member Author

hackdna commented Nov 30, 2015

Fixed as of 4c7f34b. However, the file is not displayed in the table after it is selected the following error message is logged in the browser console:

TypeError: f.options.columnDefs.forEach is not a function
    at p.buildColumns (ui-grid.min.js:7)
    at m (ui-grid.min.js:7)
    at Object.fn (angular.js:15775)
    at r.$digest (angular.js:15843)
    at r.$apply (angular.js:16125)
    at FileReader.c.onload (metadata-table-import.js:72)

@jkmarx jkmarx closed this as completed in 45cfcae Dec 3, 2015
@hackdna
Copy link
Member Author

hackdna commented Dec 3, 2015

One more issue: initial column width used to be set automatically according to the column header length to make them more readable. Now all the columns are equally narrow and headers are unreadable unless manually resized. The code that performs the calculation is here.

@hackdna hackdna reopened this Dec 3, 2015
@jkmarx
Copy link
Member

jkmarx commented Dec 3, 2015

Since we've reopened this issue, in Firefox only:
screen shot 2015-12-03 at 11 58 32 am

@hackdna
Copy link
Member Author

hackdna commented Dec 3, 2015

Thanks for bringing this up. It looks like styling is missing from buttons and drop-downs in Firefox too.

@jkmarx
Copy link
Member

jkmarx commented Dec 3, 2015

From the bootstrap components website http://getbootstrap.com/components/ :
Textual inputs only

Avoid using select elements here as they cannot be fully styled in WebKit browsers.

Avoid using textarea elements here as their rows attribute will not be respected in some cases.

@jkmarx
Copy link
Member

jkmarx commented Dec 3, 2015

@hackdna This is the default bootstrap3 styling. Chrome has it's own styling which is being applied.
screen shot 2015-12-03 at 4 38 24 pm

@jkmarx
Copy link
Member

jkmarx commented Dec 4, 2015

@flekschas @hackdna @ngehlenborg I fixed the column situation. If you agree, I'd like to close this issue and write a separate issue for tackling uniform styling between browsers and updating styling to the new style guide http://uspto.github.io/designpatterns/1.x/docs/patterns/fileUpload.html

@jkmarx
Copy link
Member

jkmarx commented Dec 4, 2015

Ref Commit 2081b4b
Ref Commit 8db5476

screen shot 2015-12-04 at 10 03 48 am

@ngehlenborg
Copy link
Contributor

I agree with that plan.

@hackdna
Copy link
Member Author

hackdna commented Dec 7, 2015

Looks good.

@hackdna hackdna closed this as completed Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants