Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui-Grid Multi-sorting Feature Unneccessary #936

Closed
jkmarx opened this issue Mar 9, 2016 · 2 comments
Closed

Ui-Grid Multi-sorting Feature Unneccessary #936

jkmarx opened this issue Mar 9, 2016 · 2 comments

Comments

@jkmarx
Copy link
Member

jkmarx commented Mar 9, 2016

Reproduce

  1. http://192.168.50.50:8000/data_sets2/c508e83e-f9ee-4740-b9c7-a7b0e631280f/#/3/
  2. In the first few columns > in the column drop down menu > select a sort for each

Observe

screen shot 2016-03-09 at 11 25 26 am

In UI-grid with external sorting, the multi-sorting feature is ignore.
"We allow sorting by the first and second columns, so that we can show a default sort and that default sort indicator being removed even when using external sorting. Our external sort routine ignores that second column however, so sorting by it has no effect."

angular-ui/ui-grid#3483

Expect

No numbers to be shown, since this is a single column sort.

@jkmarx jkmarx self-assigned this Mar 9, 2016
@jkmarx jkmarx added this to the Next milestone Mar 9, 2016
@ngehlenborg ngehlenborg removed this from the Next milestone Mar 22, 2016
@jkmarx
Copy link
Member Author

jkmarx commented Apr 22, 2016

angular-ui/ui-grid#2913

@jkmarx jkmarx added this to the v1.4.1 milestone Sep 20, 2016
@jkmarx
Copy link
Member Author

jkmarx commented Sep 20, 2016

With the latest ui-grid upgrade, this no longer appears to be an issue.

screen shot 2016-09-20 at 2 05 56 pm

@jkmarx jkmarx closed this as completed Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants