Fix for tabular metadata uploads that only contain one row #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… any other 400 error happen to occur
scottx611x
changed the title
facet_fields occurs
Current coverage is 35.24% (diff: 0.00%)@@ develop #1479 diff @@
==========================================
Files 338 338
Lines 23393 24963 +1570
Methods 0 0
Messages 0 0
Branches 1238 1337 +99
==========================================
+ Hits 8126 8798 +672
- Misses 15267 16165 +898
Partials 0 0
|
|
@scottx611x @ngehlenborg
|
jkmarx
reviewed
Oct 19, 2016
| for ( var i = 0; i < response.response.docs.length; ++i ) { | ||
| documentList.push( response.response.docs[i] ); | ||
| } | ||
|
|
||
| return documentList; | ||
| } | ||
|
|
||
|
|
||
| SolrResponse.prototype._processPivotCounts = function ( response ) { |
There was a problem hiding this comment.
self._pivotCounts = self._processPivotCounts(response)
The default value for self._pivotCount = {}
I'd recommend setting an else with {}, even though no extra errors seem to be thrown.
jkmarx
reviewed
Oct 19, 2016
| url = settings.REFINERY_SOLR_BASE_URL + core + "/select" | ||
| data = request.GET.urlencode() | ||
| try: | ||
| full_response = requests.get(url, params=data) | ||
| full_response.raise_for_status() | ||
| # Solr sends back an additional 400 here in the data_sets 1 filebrowser |
There was a problem hiding this comment.
API will stick around. It's used as a UI common services solr.js, which is used by multiple features.
hackdna
reviewed
Oct 24, 2016
| # interacts with Solr doesn't produce this extra 400 error | ||
| if ("Pivot Facet needs at least one field name" | ||
| not in full_response.content): | ||
| full_response.raise_for_status() | ||
| response = full_response.content |
There was a problem hiding this comment.
This should be in the 'else' clause of the 'try' block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463