Fixes #138
Merged
Fixes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put in happy path unit tests for returns.
Conflicts: wildlifelicensing/apps/main/tests/helpers.py
Conflicts: wildlifelicensing/apps/main/tests/helpers.py
Conflicts: requirements.txt
… host_resolve by setting a DEFAULT_HOST in env that should be the URL (with schem and port) of the running server. * fixed a warning in url patterns.
…oscar products for any new variants added.
Fix host resolve
1913 variant bug
Flag is set to true when either an email has been sent for a renewal reminder or a renewal pdf has been created for a licence. Renewals aren't sent for licences that have been amended / renewed already. A re-issue of a licence will set the flag to back to false allowing renewal reminders to be sent for reissued licences. Changed licences 'previous_licence' flag, which wasn't being used (except for being shown in reports, which would always be empty) to 'replaced_by', which is used as part of the condition as to whether to send renewal reminders. Moved renewal reminder cron job and email code out of applications app into main, where they are more relevant.
Fix profile create
Added renewal_sent flag to licences
Licence emails were sent twice.
Fix some py3 compatibilities. Enough to pass the tests
|
Reviewed 32 of 32 files at r1. Comments from Reviewable |
dbca-asi
pushed a commit
that referenced
this pull request
Feb 27, 2017
Fixed problem with being able to process declined applications and customers seeing them as still under review.
dbca-dragon
pushed a commit
to dbca-dragon/ledger
that referenced
this pull request
Mar 20, 2019
Wildlifecompliance merge latest into 6164 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! WARNING: a new env var must be set for WL to resolve the host URL in cron jobs:
DEFAULT_HOST=https://wildlifelicensing-uat.dpaw.wa.gov.auThis change is