Sprint 30-05-2017 14-06-2017 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing that fixed two bugs Added some permission mixins specific to returns
Fixed formatting of application pdf, including rendering of different field type values. Data under conditions will render indented from conditional field. Added link for PDF in officer / assessor tables. Added unit tests.
…esting Added tests for returns views permissions.
Added validation for Email User http://bugs.python.org/issue1777412
Added default period for licence type. Initial issue licence form's end date field is the start date plus the default period, or not set if the default period not set. Added unit tests for default period.
Similar to application request amendments.
…ating new session
Date of birth needs to be no less than 1900 for strformat to work.
Default period for licence
…ssuing the licence
…nsistently. Changed breadcrumbs not to show Home or Select Licence type. Added non-link bread crumb to say New/Edit/Amend/Reissue Application.
…r when uploading massive return
For application model, when calling the 'reference' property, check that there is a lodgement and sequence number, otherwise return empty string. For pdf PageTemplate, pass in list of frames, rather than just frame object. Updated pdf generators in main app pdf module to also do this. Fixed unit test descriptions.
3407 concurrent applications
2897 application pdf
Fixes for issues 3191, 3222, 3411
…nst_exceptions Consolidate dashboard against exceptions
Created data migration
Removed the BooleanField is_licence_amendment replaced it by a property.
Assessor display type
Updated migration to use new_licence rather than 'new licence' Removed template / javascript that referenced is_licence_amendment Changed success message to warning when saving conditions
3223 application type
Removed the proxy column in officer's application dashboard
… application during entry and trying to enter multiple applications simultaneously.
Created a base AuthMixin Revisit all the mixins to use the new baseclass
Fixed an error in the TemplateEmailBase who add a wrong template name.
|
Reviewed 76 of 76 files at r1. Comments from Reviewable |
dbca-dragon
pushed a commit
to dbca-dragon/ledger
that referenced
this pull request
May 27, 2019
WildlifeCompliance: licence api add filter for licence+activity lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning! This MR requires migrations.
This MR includes the following kanboad cards (https://kanboard.dpaw.wa.gov.au/?controller=BoardViewController&action=show&project_id=24):
*3407
*2728
*3226
*2897
*3133
*2759
*3132
*3221
*3222
*3220
*3268
*3411
*3287
*3223
*3191
*3224
This change is