separate workflow-examples from workflow-service #470
Conversation
There was a problem hiding this comment.
The code looks good, but I do not think that it's the best way to present this to the users. At the end, this is not composable at all.
I would like to be the jars part of the Dockerfile, so the user can push the Jar inside the Dockerfile and keep track of IDS and versions.
I cannot see how a rollback in a version will work here or how can a user can register 10 different jars to compose user flows.
Not sure if this is the right direction.
@eloycoto @masayag @pkliczewski |
| @@ -14,6 +14,7 @@ patches: | |||
|
|
|||
| images: | |||
| - name: quay.io/parodos-dev/workflow-service:main | |||
| newName: quay.io/parodos-dev/integration-service | |||
There was a problem hiding this comment.
Is there a need to create this repository on quay?
There was a problem hiding this comment.
it is only a tag. it is never pushed to quay
There was a problem hiding this comment.
should main added here, no?
There was a problem hiding this comment.
@eloycoto what do u mean?
There was a problem hiding this comment.
Should be like this:
- name: quay.io/parodos-dev/workflow-service:main
newTag: test
- newName: quay.io/parodos-dev/integration-service:main
newTag: test
- name: quay.io/parodos-dev/notification-service:main
newTag: test
There was a problem hiding this comment.
no. this is how it should be. and it works
ydayagi
force-pushed
the
flpath510
branch
5 times, most recently
from
4521f90
to
dcf9c85
Compare
|
/lgtm |
There was a problem hiding this comment.
I'm not sure if the push-image thing is implemented, I do not think so.
At the other hand, maybe the update on hack/manifest is needed, to use the image in all manifest, if not only the workflow-service without workflows examples in there.
I would check all .github/actions/ and hack/manifest/
@masayag @eloycoto @pkliczewski I don't understand what is needed. the required changes for building an image for integration tests were made. it does not effect release. |
ydayagi
force-pushed
the
flpath510
branch
4 times, most recently
from
5e081a1
to
ef0a172
Compare
build workflow-service image without workflow-examples provide workflow-examples (or user's JAR) via a PVC for integration tests create a PVC in kind and use a pod to mount it and copy the examples JAR to the PVC. FLPATH-510 https://issues.redhat.com/browse/FLPATH-510 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
|
/lgtm |
|
@eloycoto what do you think? |
There was a problem hiding this comment.
LGTM, but:
@gabriel-farache, maybe we should update the image in the operator default one?
@ydayagi did you create the image in the quay.io?
I'll notify users to use examples-service instead of workflow-service. cc @RichardW98
When we release the new version of workflow-service, the |
|
@gabriel-farache @eloycoto what do you suggest to do to finalize this PR? |
|
Quay container created: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloycoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
build workflow-service image without workflow-examples
build an image with workflow-examples for integration tests
FLPATH-510 https://issues.redhat.com/browse/FLPATH-510