Add local error class. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring users to catch a raw Exception instead of providing our own error class is bad, it encourages bad coding habits and forces users to write code that can hide real bugs. Instead, define a local subclass of Exception, and throw that instead.
|
is this done or do you want to finish mirroring C errors first? |
|
i suggest to finish mirroring @Ferroin |
|
I intend to finish mirroring the C errors first. I should hopefully have an initial version doing that some time later today. |
This provides Python Exception subclasses equivalent to each of the errors defined by the libsensors API so that they can be individually caught. It also proivdes a function to handle raising the appropriate error based on the return value of the function that caused it. Tracebacks with this are not quite as nice as they were, adding an extra function to the end, but there is unfortunately no way that I know of to avoid this that is compatible with both Python 2 and Python 3.
|
Updated, with some minimal testing. I've added appropriate secondary inheritance for exceptions based on what they are as well, so you can do sane things like trying to catch |
paroj
requested changes
Nov 14, 2018
paroj
approved these changes
Nov 14, 2018
Ferroin
added a commit
to Ferroin/sensors.py
that referenced
this pull request
Nov 20, 2018
I accidentally forgot to test paroj#2 properly beyond the first commit. As a result, I accidentally introduced both a Python 2 compatibility issue (`PermissionsError` was not introduced until a recent version of Python 3), and multiple typos that cause the module to fail to load regardless of Python version. This fixes both.
paroj
pushed a commit
that referenced
this pull request
Nov 20, 2018
I accidentally forgot to test #2 properly beyond the first commit. As a result, I accidentally introduced both a Python 2 compatibility issue (`PermissionsError` was not introduced until a recent version of Python 3), and multiple typos that cause the module to fail to load regardless of Python version. This fixes both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring users to catch a raw Exception instead of providing our own error class is bad, it encourages bad coding habits and forces users to write code that can hide real bugs.
Instead, define a local subclass of Exception, and throw that instead.