Run tests on s390x #58
Conversation
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
requested review from
achille-roussel,
asubiotto,
brancz,
fpetkovski,
joe-elliott,
kevinburkesegment,
mdisibio,
Pryz and
thorfour
as code owners
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
Interesting that this is failing with I'm not sure any of the maintainers have access to this kind of hardware to help diagnose. |
|
@joe-elliott we only have assembly-optimized code for amd64 at this time, so on s390x we would use the Go implementation whether the tag is specified or not. This failure is interesting: There's very little going on in this test so we could probably use it to track down the issue, it also highlights how it's likely the assumption of little-endian that is breaking:
Everywhere we assume a little-endian architecture we would need to provide an alternative version of the functions for big-endian. |
|
Failing tests are:
What is interesting is that TestDictionary and TestBuffer test are passing for int64, double, uuid |
|
Hi @pavolloffay, We see that many of the test cases are failing right now on s390x, and we tried our best to handle the testcase failure by changing endianness of the data types.. Even though, it helps in succeeding at some place, but it eventually fails at later stages. These are testcase groups that were failing initially when we started looking into the parquet issue. Out of the above testcases, we have successfully fixed “TestConvertValue/string_to_int96” testcase… We need your help and support in understanding the complete parquet package and its functionality, so that we can work on fixing the other testcase failures.. Warm Regards, |
|
hi @Vishwanatha-HD, thanks for looking into this issue. I have also identified that these tests are failing and IIRC I was able to fix one test but that resulted in other failing tests that were passing previously. Our team does not have a good understanding of parquet-go library. We haven't worked with it directly. Perhaps folks from Grafana could assist with some capacity (e.g. @joe-elliott). Feel free to reach out to me on the CNCF or RH slack. |
Updates #56
This PR demonstrates that tests do not run on s390x (IBM Z, bigendian) architecture.