Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./t/pmc/multidispatch.t: Can test be un-TODO-ed? #328

Open
jkeenan opened this issue Nov 21, 2009 · 2 comments
Open

./t/pmc/multidispatch.t: Can test be un-TODO-ed? #328

jkeenan opened this issue Nov 21, 2009 · 2 comments

Comments

@jkeenan
Copy link
Contributor

jkeenan commented Nov 21, 2009

In the file in question, we see:

 726 pir_output_is( <<'CODE', <<'OUT', "MMD on PMC types - Any", todo => 'RT #41     374' );
 727 
 728 .sub main :main
 729     $P0 = new ['String']
 730     $P0 = "ok 1\n"
 731     $P1 = new ['PerlInt']
 732     $P1 = "ok 2\n"
 733     p($P0)
 734     p($P1)
 735     $P0 = new ['PerlInt']
 736     $P0 = 42
 737     p($P0)
 738     $P0 = new ['PerlInt']
 739     $P0 = 43
 740     q($P0)
 741 .end

[http://rt.perl.org/rt3/Ticket/Display.html?id=41374 RT #41374] was resolved without dealing with the ''todo'' in the test.

Originally http://trac.parrot.org/parrot/ticket/1320

@jkeenan
Copy link
Contributor Author

jkeenan commented Nov 21, 2009

See also this part of the test file:

 812 pir_output_is( <<'CODE', <<'OUTPUT',
    "add as method - inherited", todo => '     TT #1320' );
 813 .sub main :main
 814     .local pmc d, l, r
 815     .local pmc pint
 816     pint = subclass 'Integer', 'PInt'
 817     l = new ['PInt']
 818     r = new ['PInt']
 819     l = 3
 820     r = 39
 821     d = l."add"(r, d)
 822     print d
 823     print "\n"

@jkeenan
Copy link
Contributor Author

jkeenan commented Aug 29, 2010

As of today, this file still has two TODO items tracked in this ticket (as well as several tracked in TT #452).

not ok 19 - MMD on PMC types - Any # TODO TT #1320
#   Failed (TODO) test 'MMD on PMC types - Any'
#   at ./t/pmc/multidispatch.t line 644.
# Exited with error code: 1
# Received:
# Class '[ 'PerlInt' ]' not found
# current instr.: 'main' pc 6
   (/Users/jimk/work/parrot/t/pmc/multidispatch_19.pir:5)
#
# Expected:
# String ok 1
# PSt ok 2
# Any    42
# Any    43
#
ok 20 - add as function - Int, Float
ok 21 - add as method
not ok 22 - add as method - inherited # TODO TT #1320
#   Failed (TODO) test 'add as method - inherited'
#   at ./t/pmc/multidispatch.t line 730.
# Exited with error code: 1
# Received:
# Method 'add' not found for invocant of class 'PInt'
# current instr.: 'main' pc 24
   (/Users/jimk/work/parrot/t/pmc/multidispatch_22.pir:9)
#
# Expected:
# 42
#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant