Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure.pl from tools/dev/create_language.pl doesn't play nice with git #609

Open
arnsholt opened this issue Feb 10, 2011 · 3 comments
Open

Comments

@arnsholt
Copy link

The Configure.pl script generated by tools/dev/create_language.pl clones Parrot from GitHub, but it's not quite right. It still thinks build/PARROT_REVISION contains a numeric revision number, not a tag or checksum, which makes it emit this error:

Argument "RELEASE_3_0_0" isn't numeric in addition (+) at Configure.pl line 25, <$REQ> line 1.

The corresponding build/gen_parrot.pl has a similar problem:

Argument "RELEASE_3_0_0" isn't numeric in addition (+) at build/gen_parrot.pl line 31, <$REQ> line 1.

Perhaps the simplest way to fix this would be to adapt the solution used in Rakudo's Configure.pl.

Originally http://trac.parrot.org/parrot/ticket/2003

@jkeenan
Copy link
Contributor

jkeenan commented Feb 12, 2011

Replying to arnsholt:

Perhaps the simplest way to fix this would be to adapt the solution used in Rakudo's Configure.pl.

Adding link to where that program is stored:  Rakudo's Configure.pl

@jkeenan
Copy link
Contributor

jkeenan commented Feb 13, 2011

See also TT #2009.

@leto
Copy link
Member

leto commented Feb 21, 2011

This is most of the code that needs to be ported/borrowed:

 https://github.com/rakudo/rakudo/blob/master/build/lib/Parrot/CompareRevisions.pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants