New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pmc2c requires major refactoring. #658
Comments
Replying to bacek:
Here's where that file is mentioned in our source code. fns . | xargs grep -nE 'PMC(/|::)RO' ./lib/Parrot/Pmc2c/PMC/default.pm:50: my $ro = Parrot::Pmc2c::PMC::RO->new($self); ./lib/Parrot/Pmc2c/PMC/RO.pm:23:package Parrot::Pmc2c::PMC::RO; ./lib/Parrot/Pmc2c/PMC/RO.pm:68: @{ ref($self) . '::ISA' } = "Parrot::Pmc2c::PMC::RO"; ./lib/Parrot/Pmc2c/PMCEmitter.pm:32:use Parrot::Pmc2c::PMC::RO (); ./lib/Parrot/Pmc2c/PMCEmitter.pm:218: $self->ro( Parrot::Pmc2c::PMC::RO->new($self) ) ./lib/Parrot/Pmc2c/Method.pm:205: lib/Parrot/Pmc2c/PMC/RO.pm ./ports/cygwin/README:846: /usr/lib/parrot/1.0.0/tools/lib/Parrot/Pmc2c/PMC/RO.pm ./ports/cygwin/README:1232: /usr/share/doc/parrot/1.0.0/html/lib/Parrot/Pmc2c/PMC/RO.pm.html ./config/auto/pmc.pm:69: lib/Parrot/Pmc2c/PMC/RO.pm ./MANIFEST:1161:lib/Parrot/Pmc2c/PMC/RO.pm [devel]lib
./lib/Parrot/Pmc2c/PMC/RO.pm is also the subject of TT #1240. |
Replying to bacek:
PMCEmitter.pm no longer exists. This is what I found when grepping: $ ack extra_vt * lib/Parrot/Pmc2c/PMC.pm 1051: my %extra_vt; 1052: $extra_vt{ro} = $self->{ro} if $self->{ro}; 1126: for my $k ( keys %extra_vt ) { 1470: my $get_extra_vtable = ''; 1473: $get_extra_vtable .= " vt = Parrot_default_ro_get_vtable(interp);\n"; 1476: $get_extra_vtable .= " vt = Parrot_${first_parent}_ro_get_vtable(interp);\n"; 1480: $get_extra_vtable .= " Parrot_${parent_name}_ro_update_vtable(vt);\n"; 1499: $get_extra_vtable .= " Parrot_${classname}_ro_update_vtable(vt);\n"; 1507:$get_extra_vtable
kid51 |
Old "mmd" stuff was removed in d0f90dd. Additional vtables handling is lta though. -- Bacek |
@bacek: Is there anything we need to do for this ticket? Can we close it, and maybe open new tickets for specific issues? |
@Whiteknight I think we can close it. Hopefully all this PMC nonsense will be killed by 6model. |
After working on #631 Pmc2c has changed and requires some refactorings. For example
Originally http://trac.parrot.org/parrot/ticket/650
The text was updated successfully, but these errors were encountered: