Round coverage down #257
Closed
Round coverage down #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coverage percentage is rounded down instead of rounding to the nearest tenth. This prevents a project with a large number of lines from passing with 100.0% coverage when there are actually lines that are not covered.
|
taken care of in #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage percentage is rounded down instead of rounding to the
nearest tenth. This prevents a project with a large number of lines from
passing with 100.0% coverage when there are actually lines that are not
covered.
I can imagine wanting this to be a config option instead, while keeping the
current behavior as default, but I thought I'd throw out this PR to start the
discussion at least.