chore: PathReader.base_path config #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the `PathReader.base_path` function to try reading from the `Application` first, using the current method as a fallback mechanism in case the config is not available. The reason for this change is that we want to instrument a running elixir app while executing some acceptance tests and `Mix.Project.config_files` does not have all the necessary information to infer the path.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the
PathReader.base_pathfunction to try readingfrom the
Applicationfirst, using the current method as a fallbackmechanism in case the config is not available.
The reason for this change is that we want to instrument a running
elixir app while executing some acceptance tests and
Mix.Project.config_filesdoes not have all the necessary informationto infer the path.