-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return {:error, err} tuples instead of throwing errors #52
Comments
Thanks for the feedback. In erlang/elixir term, it would be better to use the more-standard one you indicated. It was implemented in the very early phase for simplification of the interface. |
It definitely is a breaking change, but assuming you are following semver, it's not really a problem as your library hasn't even reached the 1.0 milestone yet. Making the changes and releasing it as 0.8 or something would be perfectly fine/normal in the semver world, and to me, this kind of change is definitely something that you'd want to have for any kind of 1.0 release. I'll try to work through it a bit over the next few weeks and see if I can come up with a full PR for the switchover |
Any progress on this? |
Still working on it. I'm actually down at ElixirConf currently, but haven't finished this up yet. |
No rush, just curious 👍 |
What was the original design decision to
raise
errors (e.g. inExTwitter.Api.Base
) instead of returning an error tuple? As ExTwitter users we are forced totry ... rescue
code instead of just pattern matching against a more-standard{:ok, [...]}
or{:error, reason}
type return?Just curious.
The text was updated successfully, but these errors were encountered: