Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Maps on request_body matcher #210

Closed
wants to merge 1 commit into from

Conversation

scudelletti
Copy link
Contributor

@scudelletti scudelletti commented Aug 9, 2023

Hello there! 👋
First of all thanks for maintaining this library! It's awesome and I use it a lot!

I've noticed that after upgrading to Elixir 1.15 - OTP 26 some tests started failing due to the order of keys/values changing when encoding the JSON body.

I know I can write a custom matcher or try to write a regexp but I believe this may be useful to more people too.
Would such feature be of interest?

This PR implementation is not ideal so please let me know what implementation would you prefer in case you like the feature. I also thought about adding a new option like :request_on_json_body. I'm open to suggestions.

@coveralls
Copy link

Coverage Status

coverage: 89.969% (-2.3%) from 92.248% when pulling 1d4bb63 on scudelletti:ds-support-json-body into 406af2d on parroty:master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 89.969% (-2.3%) from 92.248% when pulling 1d4bb63 on scudelletti:ds-support-json-body into 406af2d on parroty:master.

@coveralls
Copy link

Coverage Status

coverage: 92.438% (+0.2%) from 92.248% when pulling 1d4bb63 on scudelletti:ds-support-json-body into 406af2d on parroty:master.

@parroty
Copy link
Owner

parroty commented Aug 24, 2023

Thanks for the PR, and I'm very sorry being late to respond 🙇 . I believe #211 is addressing the same issue, I am wondering 211 might be simpler implementation. Do you think merging 211 resolve the issue you're facing (or this one is better?). I appreciate your feedback 🙇 .

@scudelletti
Copy link
Contributor Author

scudelletti commented Aug 24, 2023

Hi @parroty, thank you for the reply, you are very kind.

I agree, #211 seems better suited and solves the same issue.
I'll close this PR.

I wish you a lovely day! 🙇

@scudelletti scudelletti deleted the ds-support-json-body branch August 24, 2023 16:29
@parroty
Copy link
Owner

parroty commented Aug 27, 2023

Thank you for the PR and comments 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants