Refactor Converters, Filter header values. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All 3 adapter converters were sharing a set of common functions so they've been extracted out into their own module called ExVCR.Converter. It implements the methods on the converters using the __using__ callback. They are all overridable.
Headers were unable to be filtered, now they're filtered the same way as body filters using ExVCR.Filter.filter_sensitive_data.
parroty
added a commit
that referenced
this pull request
Mar 3, 2014
Refactor Converters, Filter header values.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of my applications I'm using ExVCR but need to parse out the value of an API key in the headers as well as the body.
This PR removes all the common code from the 3 adapter converters and places it into a new module called
ExVCR.Converter. All of the methods are overridable.Finally,
ExVCR.Filter.filter_sensitive_datais called on all of the header values.