Fix wrong request arguments handling for httpc adapter #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
wrong-httpc-request-handling
branch
from
55a63af
to
99bb044
Compare
|
+1, the checks failed because of coverage posting to 3rd party failed |
parroty
added a commit
that referenced
this pull request
Jan 13, 2016
Fix wrong request arguments handling for httpc adapter
|
Thanks, and sorry about the flaky build. |
|
Travis seems slow and taking time to complete testing.. I'll be pushing hex package once after completed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body was extracted from the wrong place in
generate_keys_for_request. By the way, I've cleaned the function up a bit.