Load configuration for cassette paths for mix tasks #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2017 12:29
….Tasks NOTE: Falls back to defaults if configuration is not specified.
|
@parroty Thanks for taking the time to make this project and to look at this PR! ❤️ ❤️ ❤️ |
|
Thanks for digging into the issue item! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When running the
Mixtasks defined in this project, they would only use the hard-coded default paths for recorded and custom cassettes and not consider the config. This demonstrates different configuration behavior between managing cassette data when running tests and managing cassette data from mix tasks.Proposed Changes
These changes now look at the
Mix.Configrelated toexvcrand use those directories if they are not specified on the CLI and then fallback to the defaults if a custom config is not used in both the context of the project'sMixtasks and running tests.References
Related to Issue #82