forked from antlr/antlr4
-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fold in Mike Lischke's PR antlr#2065 to make the output directory exa…
…ct if you use a new option `-Xexact-output-dir`. Fixes antlr#1087, Fixes antlr#753, Fixes antlr#638.
- Loading branch information
Showing
1 changed file
with
59 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121e767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the changes in the TokenVocabParser.java file. These are important as well to improve *.tokens import. It makes it possible to load .tokens files from the grammar's folder (think of predefined tokens, not generated ones).
121e767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, those didn't make it? crap. ok, let me look.
121e767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-lischke Seems to be there in the master branch: https://github.com/antlr/antlr4/blob/master/tool/src/org/antlr/v4/parse/TokenVocabParser.java Are those the changes you're talking about
121e767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I checked the code (did a fresh pull) to see if everything is there and it wasn't. Hence my comment. But now it looks all ok.
121e767
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. yeah, all the branching can make it confusing.