Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve _ctreeviz_univar() #227

Merged
merged 9 commits into from Jan 5, 2023
Merged

Improve _ctreeviz_univar() #227

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6c0fb9
Compute bins only when needed
mepland Dec 30, 2022
984567b
Fix crash for 0 count bins
mepland Dec 30, 2022
5329b8e
Match other rectangle rect_edge color style
mepland Dec 30, 2022
4e1b6a2
Add ValueError for unrecognized gtype
mepland Dec 30, 2022
d60c4c1
Fix split heights changing in for loop
mepland Dec 30, 2022
3b12865
Make new 'preds' key in show param to separately
mepland Dec 30, 2022
b735428
Added tesselation_alpha to let user make
mepland Dec 30, 2022
3a72aa2
Move preds boxes below x-axis to avoid overlap with histogram
mepland Jan 4, 2023
8db4ea5
Merge branch 'dev' into improve_ctreeviz_univar
parrt Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion dtreeviz/trees.py
View file
Open in desktop
Expand Up @@ -1498,14 +1498,16 @@ def _ctreeviz_univar(shadow_tree,

splits = [node.split() for node in shadow_tree.internal]
splits = sorted(splits)
bins = [ax.get_xlim()[0]] + splits + [ax.get_xlim()[1]]

if 'splits' in show: # this gets the horiz bars showing prediction region
pred_box_height = .07 * ax.get_ylim()[1]
bins = [ax.get_xlim()[0]] + splits + [ax.get_xlim()[1]]
for i in range(len(bins) - 1):
left = bins[i]
right = bins[i + 1]
inrange = y_train[(X_train >= left) & (X_train <= right)]
if 0 == len(inrange):
parrt marked this conversation as resolved.
Show resolved Hide resolved
continue
values, counts = np.unique(inrange, return_counts=True)
pred = values[np.argmax(counts)]
rect = patches.Rectangle((left, 0), (right - left), pred_box_height, linewidth=.3,
Expand Down