Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #50: added type check and conversion for y_train parameter #51

Merged
merged 1 commit into from Sep 14, 2019
Merged

Resolves #50: added type check and conversion for y_train parameter #51

merged 1 commit into from Sep 14, 2019

Conversation

Ashafix
Copy link
Contributor

@Ashafix Ashafix commented Sep 14, 2019

  • Added a check if non-numerical values are passed as input parameters.
  • Tries to convert non-numerical values and throws an exception if it fails.
  • Added a check for correct shape of input parameter

@Ashafix Ashafix changed the title added type check and conversion for y_train parameter Resolves #50: added type check and conversion for y_train parameter Sep 14, 2019
@Ashafix Ashafix mentioned this pull request Sep 14, 2019
Closed
@parrt parrt added the enhancement New feature or request label Sep 14, 2019
@parrt
Copy link
Owner

parrt commented Sep 14, 2019

Thanks!

@parrt parrt merged commit fbe416d into parrt:master Sep 14, 2019
@parrt parrt added this to the 0.7 milestone Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ashafix @parrt