-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default font's spacing on mac incorrect #34
Comments
Weird. is Consolas font installed on your system? Is it Intel or M1? |
Consolas wasn't installed in my environment (Intel). The fallback font is "Dejavu Sans", which fails to display the code as seen above. Advising users to install the font may involve recreating the environment etc. An alternative solution to consider is to explicitly specify a fallback font. This is much more user friendly in my opinion at nearly no burden on the package. For instance, "DejaVu Sans Mono" works well. This can be trivially achieved providing a sequence of font names: |
agreed this is a good change. I guess your PR only sets the arg default, but there's no code to fall back to the indicated font. Font name is now a tuple by default, which is really a comment for the developer. Shouldn't there be logic to check for font installations and use one that works? |
Matplotlib handles all that logic, this PR just changes the default:
|
You are kidding me!? Wow. that's insane. You just took me to school! |
Compare with courier new
Relevant code:
The text was updated successfully, but these errors were encountered: