PA-22319 - Make go-saml handle signatures on response XML (Georgia Pacific) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexvalenzuelac I'm going to remove @sagard and I as reviewers until this is ready for review. |
alexvalenzuela
commented
Jan 15, 2020
| @@ -9,9 +9,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| xmlResponseID = "urn:oasis:names:tc:SAML:2.0:protocol:Response" | |||
There was a problem hiding this comment.
this was moved by golangci-lint
alexvalenzuela
commented
Jan 15, 2020
| @@ -134,3 +134,11 @@ func Decrypt(xml string, privateKeyPath string) ([]byte, error) { | |||
| func deleteTempFile(filename string) { | |||
| _ = os.Remove(filename) | |||
| } | |||
|
|
|||
| func LoadXml(certPath string) (string, error) { | |||
There was a problem hiding this comment.
Let's keep this function in case if we have a Request/Response and we need to test/validate somethig with it
…ure on response, assertion and encryptedassertion
alexvalenzuela
force-pushed
the
PA-22319-HandleResponseAssertionSignature
branch
from
3342a0c
to
8de6d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created unit tests and add additional validation for signature on