Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WKWebView instead of deprecatd UIWebView #1

Merged
merged 2 commits into from Dec 10, 2019

Conversation

mman
Copy link

@mman mman commented Oct 24, 2019

Replaces usage of as UIWebView deprecated since iOS 8 with WKWebView.

This allows Bolts-ObjC to continue being built as a subproject or via Carthage for iOS 13, macOS 10.15 and macCatalyst 13.

@noobs2ninjas
Copy link
Member

Hey mman.
Looks like we got a error on the iOS test.

Testing failed:
"OBJC_CLASS$_WKWebView", referenced from:
Linker command failed with exit code 1 (use -v to see invocation)
** TEST FAILED **

@mman
Copy link
Author

mman commented Nov 22, 2019

Looking at that, I'm not sure how exactly travis does things, but I have tried to link both tests and Bolts with WebKit.framework so let's see what happens.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1b247a7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   99.16%           
=========================================
  Files             ?        8           
  Lines             ?      478           
  Branches          ?        0           
=========================================
  Hits              ?      474           
  Misses            ?        4           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b247a7...76a96f3. Read the comment docs.

@noobs2ninjas
Copy link
Member

@mman

So I think what needs to happen is we need to update travis config file to use Xcode 11. I think its using an Xcode environment from before WKWebView was a thing. Also, we need to remove or update the code coverage.

Also, we need to go ahead and remove the iOS only files anyway from the macOS build. Think you could go through each targets build phase and check to see that those file say iOS only? Seems on Xcode 11 that most iOS only targets get converted to catalyst and added "macOS + iOS" to every single file on the "Compile Sources" list.

Heres what I mean:
65639164-300ceb00-dfad-11e9-8e47-d43d5054e9cc

@noobs2ninjas
Copy link
Member

In fact this change alone probably would have fixed our builds. Once you get this done I'll update the podspec and carthage on Parse and ParseLiveQuery.

@noobs2ninjas
Copy link
Member

@mman Im going to go ahead and merge this. The errors are coming from xctest signing which isnt an issue with your code at that point.

@noobs2ninjas noobs2ninjas merged commit b982d4c into parse-community:master Dec 10, 2019
@noobs2ninjas
Copy link
Member

Hey @mman. Could you take a look at my closed pull request. I updated the project to build with Xcode 11 and all the sudden some tests started breaking dealing with app linking. I commented those out and updated a few other things to get our tests passing.

@mman
Copy link
Author

mman commented Dec 10, 2019

Hi @noobs2ninjas, what exactly do you want me to check out please? I'm not that familar with the build infrastructure yet. Please send me a link and I'll take a look. Thanks.

@noobs2ninjas
Copy link
Member

@mman I think we are ok at this point. Getting parse to build just fine with this fork.

@mman
Copy link
Author

mman commented Jan 6, 2020

Excellent, I plan to get back to this stuff during the next weeks, will re-test as well. Great job and thanks for merging! Martin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants