perf: remove unnecessary extra child traversal in collectDirtyChildren (

#1058)
parse-community · Nov 3, 2021 · 1844b3e · 1844b3e
1 parent 7cff2ae
commit 1844b3e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/parse/src/main/java/com/parse/ParseObject.java b/parse/src/main/java/com/parse/ParseObject.java
@@ -590,7 +590,9 @@ protected boolean visit(Object node) {
                 // Check for cycles of new objects. Any such cycle means it will be
                 // impossible to save this collection of objects, so throw an exception.
                 if (object.getObjectId() != null) {
-                    seenNew = new HashSet<>();
+                    if (!seenNew.isEmpty()) {
+                        seenNew = new HashSet<>();
+                    }
                 } else {
                     if (seenNew.contains(object)) {
                         throw new RuntimeException("Found a circular dependency while saving.");
@@ -605,7 +607,6 @@ protected boolean visit(Object node) {
                 if (seen.contains(object)) {
                     return true;
                 }
-                seen = new HashSet<>(seen);
                 seen.add(object);
 
                 // Recurse into this object's children looking for dirty children.