Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating Facebook webview #1104

Closed
kaushikmurthy opened this issue Oct 5, 2021 · 5 comments
Closed

Deprecating Facebook webview #1104

kaushikmurthy opened this issue Oct 5, 2021 · 5 comments
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@kaushikmurthy
Copy link

https://developers.facebook.com/docs/facebook-login/android/deprecating-webviews

Since Facebook is deprecating the webview, I hope this is going to be taken care in the future SDK releases.
If it is already taken care, please let me know the version of the SDK.
@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Oct 7, 2021
@mtrezza
Copy link
Member

mtrezza commented Oct 7, 2021 •
edited

I classified this as a bug preemptively as the upcoming change on Facebook's side is expected to cause issues. The current version of the Android SDK is using com.facebook.android:facebook-login:6.3.0

@mtrezza mtrezza added bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) severity:high labels Oct 7, 2021
@sommye-ctr
Copy link
Contributor

Are there any breaking changes in migrating from Facebook's Android SDK current version (6.3.0) to the latest version (8.2.0 - recommended)?

@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2021

It's a jump of 2 major version upgrades, so it is quite likely. But I assume it will be just some minor changes. Do you want to give it a try and open a PR?

@sommye-ctr
Copy link
Contributor

I am not much experienced but I'll surely give it a try as soon as I get time.

@sommye-ctr sommye-ctr mentioned this issue Oct 9, 2021
Merged
@mtrezza
Copy link
Member

mtrezza commented Oct 9, 2021

Closing via #1105

@mtrezza mtrezza closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtrezza @kaushikmurthy @sommye-ctr