Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Facebook SDK #1105

Merged
merged 5 commits into from Oct 9, 2021
Merged

Conversation

sommye-ctr
Copy link
Contributor

@sommye-ctr sommye-ctr commented Oct 9, 2021

In accordance with #1104 I changed the Facebook for Android SDK version from 6.3.0 to 8.2.0.
Also, as recommended by RoboElectric, I have updated its version to 4.2.1 to fix the parsing in windows.

@mtrezza
Copy link
Member

mtrezza commented Oct 9, 2021

Thanks for the PR! Let's merge #1095 first so we also have the CI working.

@azlekov
Copy link
Contributor

azlekov commented Oct 9, 2021

@mtrezza as this PR overlaps a lot with #1095, may I update the Facebook SDK there as well? What do you think?

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #1105 (5f3bcba) into master (a977d11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1105   +/-   ##
=========================================
  Coverage     65.06%   65.06%           
  Complexity     2208     2208           
=========================================
  Files           122      122           
  Lines          9463     9463           
  Branches       1317     1317           
=========================================
  Hits           6157     6157           
  Misses         2799     2799           
  Partials        507      507           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a977d11...5f3bcba. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Oct 9, 2021

Interesting that this only required to bump the SDK but no code changes.

@mtrezza mtrezza changed the title Upgrading Facebook for android SDK fix: upgrade Facebook SDK Oct 9, 2021
@mtrezza mtrezza merged commit 6f4bdb0 into parse-community:master Oct 9, 2021
@azlekov
Copy link
Contributor

azlekov commented Oct 10, 2021

@mtrezza I will take care if there are reported new issues regarding Facebook sdk upgrade. Currently I do not have project to test with.

@sommye-ctr
Copy link
Contributor Author

I think I'll be working on a project using the Facebook SDK soon. I'll update if there's any problem.

@mtrezza
Copy link
Member

mtrezza commented Oct 10, 2021

I should also be able to test in the next days. I merged it anyway for an alpha release and if really FB doesn’t work, then we are actually missing some tests.

github-actions bot pushed a commit to mtrezza/Parse-SDK-Android that referenced this pull request Oct 10, 2021
# [2.0.0](1.22.0...2.0.0) (2021-10-10)

### Bug Fixes

* remove GCM module ([parse-community#1091](https://github.com/mtrezza/Parse-SDK-Android/issues/1091)) ([aa16bcf](aa16bcf))
* upgrade Facebook SDK ([parse-community#1105](https://github.com/mtrezza/Parse-SDK-Android/issues/1105)) ([6f4bdb0](6f4bdb0))

### Features

* update all dependencies and modernize the source base ([parse-community#1095](https://github.com/mtrezza/Parse-SDK-Android/issues/1095)) ([a977d11](a977d11))

### BREAKING CHANGES

* CHANGE

Support for Google Cloud Messaging (GCM) is removed, use Firebase Cloud Messaging instead. See the [Google developer documentation](https://developers.google.com/cloud-messaging/faq) for more details and migration assistance. ([aa16bcf](aa16bcf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants