Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parse from endpoints path #5

Closed
wants to merge 1 commit into from

Conversation

PiotrWpl
Copy link
Contributor

"parse" shouldn't be included in endpoint path, because if someone have domain dedicated just for Parse service (Parse is installed in root dir), this plugin will not work.

PiotrWpl added a commit to PiotrWpl/FlutterParseSDK that referenced this pull request Oct 12, 2018
I had added:
* missing body for user creation request
* changed URI creation for login, because previous one didn't worked. Full url was setted as a path
* this commit also include changes from this pull request parse-community#5
Copy link
Member

@phillwiggins phillwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. I have a Parse setup at the moment which works with this URL. I think that this is standard practice.

Do you have an instance of Parse that this wouldn't work for? If that's correct then we possibly need to inject the url as a paramenter, but would be an ugly experience for the user to try and figure this out.

@PiotrWpl
Copy link
Contributor Author

For example in my company we have a dedicated domain for Parse service. If in this plugin "parse" will be hardcoded in path, people like I, will not be able to use it.
Whats more, when I'm using Parse SDK for Android or iOS, there they also not hardcode "parse" in path, You as a developer are responsible to add it to yours url if you have it configured like this, please check:

@phillwiggins
Copy link
Member

Apologies, it's been a long day. I see my mistake. Will correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants