New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incorrect results when ParseQuery
contains special characters
#866
Conversation
Thanks for opening this pull request!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #866 +/- ##
==========================================
+ Coverage 38.51% 39.50% +0.98%
==========================================
Files 60 60
Lines 3331 3339 +8
==========================================
+ Hits 1283 1319 +36
+ Misses 2048 2020 -28
☔ View full report in Codecov by Sentry. |
I will await for my other PR (#860) to be merged to see all the added tests and changes. |
@parse-community/flutter-sdk-review This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
ParseQuery
contains special characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
New Pull Request Checklist
Issue Description
Closes: #841
Approach
use
Uri.encodeComponent(URLComponent);
This will produce an encoded query value:
?where={"Name":"AB%2BAB"}
The encoded equivalent of:
?where={"Name": "AB+AB"}
TODOs before merging