Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Building web app fails because dbDirectory does not exist in core_store_directory_web #948

Merged
merged 26 commits into from Jul 10, 2023
Merged

fix: Building web app fails because dbDirectory does not exist in core_store_directory_web #948

merged 26 commits into from Jul 10, 2023

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Jul 3, 2023

Pull Request

Issue

move dbDirectory to core_store_sembast

Closes: #947

Approach

n/a

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (ac682f2) 39.31% compared to head (854e42d) 39.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
+ Coverage   39.31%   39.34%   +0.02%     
==========================================
  Files          60       60              
  Lines        3355     3355              
==========================================
+ Hits         1319     1320       +1     
+ Misses       2036     2035       -1     
Impacted Files Coverage Δ
packages/flutter/lib/parse_server_sdk_flutter.dart 20.00% <ø> (ø)
...utter/lib/src/storage/core_store_directory_io.dart 100.00% <ø> (+13.04%) ⬆️
...es/flutter/lib/src/storage/core_store_sembast.dart 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@keanallen
Copy link

keanallen commented Jul 5, 2023

up for this

@mbfakourii mbfakourii requested a review from a team July 5, 2023 09:32
@sgehrman

This comment was marked as off-topic.

@sgehrman

This comment was marked as off-topic.

@sgehrman
Copy link

sgehrman commented Jul 7, 2023

why does it take a week to merge a super tiny change? Get a clue, people are using this package. Should have taken 5 minutes to post a new build.

@keanallen
Copy link

keanallen commented Jul 7, 2023

why does it take a week to merge a super tiny change? Get a clue, people are using this package. Should have taken 5 minutes to post a new build.

It has to be tested first to ensure quality and lessen bugs

@mtrezza
Copy link
Member

mtrezza commented Jul 7, 2023

@sgehrman It's important to remember that this package is maintained by open source volunteers who generously contribute their time and effort. While it's understandable to be eager for updates, let's appreciate the hard work of the volunteers and the fact that they are dedicating their free time to support this project. If you have specific concerns or suggestions, it's helpful to express them respectfully and engage in constructive discussions. If you want to help to get this pull request merged faster, feel free to test it out and post your feedback here.

packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved
packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title fix: dbDirectory not exist in core_store_directory_web in web fix: dbDirectory does not exist in core_store_directory_web in web Jul 7, 2023
packages/flutter/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting for CI to pass

@mtrezza mtrezza changed the title fix: dbDirectory does not exist in core_store_directory_web in web fix: Building web app fails because dbDirectory does not exist in core_store_directory_web Jul 10, 2023
@mtrezza mtrezza merged commit d00f545 into parse-community:master Jul 10, 2023
14 of 15 checks passed
@mbfakourii mbfakourii deleted the fix_dbDirectory_in_web branch October 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Web application failed
4 participants