New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Building web app fails because dbDirectory
does not exist in core_store_directory_web
#948
fix: Building web app fails because dbDirectory
does not exist in core_store_directory_web
#948
Conversation
refactor: Add `CONTRIBUTING.md`
Thanks for opening this pull request! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
==========================================
+ Coverage 39.31% 39.34% +0.02%
==========================================
Files 60 60
Lines 3355 3355
==========================================
+ Hits 1319 1320 +1
+ Misses 2036 2035 -1
☔ View full report in Codecov by Sentry. |
up for this |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
why does it take a week to merge a super tiny change? Get a clue, people are using this package. Should have taken 5 minutes to post a new build. |
It has to be tested first to ensure quality and lessen bugs |
@sgehrman It's important to remember that this package is maintained by open source volunteers who generously contribute their time and effort. While it's understandable to be eager for updates, let's appreciate the hard work of the volunteers and the fact that they are dedicating their free time to support this project. If you have specific concerns or suggestions, it's helpful to express them respectfully and engage in constructive discussions. If you want to help to get this pull request merged faster, feel free to test it out and post your feedback here. |
packages/flutter/example/linux/flutter/generated_plugin_registrant.cc
Outdated
Show resolved
Hide resolved
dbDirectory
not exist in core_store_directory_web
in webdbDirectory
does not exist in core_store_directory_web
in web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Waiting for CI to pass
dbDirectory
does not exist in core_store_directory_web
in webdbDirectory
does not exist in core_store_directory_web
Pull Request
Issue
move
dbDirectory
tocore_store_sembast
Closes: #947
Approach
n/a
Tasks