Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fields in LiveQueryClient.resubscribe to keys #2180

Closed
akichim21 opened this issue Jun 22, 2024 · 8 comments · Fixed by #2184
Closed

Change fields in LiveQueryClient.resubscribe to keys #2180

akichim21 opened this issue Jun 22, 2024 · 8 comments · Fixed by #2184
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@akichim21
Copy link

akichim21 commented Jun 22, 2024

Issue Description

Change fields in LiveQueryClient.resubscribe to keys

https://github.com/parse-community/Parse-SDK-JS/blob/alpha/src/LiveQueryClient.ts#L303

Steps to reproduce

  • execute resubscribe
  • parse-server logs
    • error | Connect message error Additional properties not allowed
    • info | Create new client: xxxx
    • many connection

Actual Outcome

  • no error

Environment

Server

Copy link

Thanks for opening this issue!

@akichim21 akichim21 changed the title Change fields in LiveQueryClient.subscribe to keys Change fields in LiveQueryClient.resubscribe to keys Jun 22, 2024
@dplewis
Copy link
Member

dplewis commented Jun 22, 2024

Please update Parse Server and JS SDK to the latest version, this should fix your issue.

@akichim21
Copy link
Author

akichim21 commented Jun 23, 2024

@dplewis
Hi.
In 5.2.0-alpha.2 it was still fields.
Which version?
The resubscribe one, not the subscribe one.

@dplewis
Copy link
Member

dplewis commented Jun 23, 2024

Oh I see. This is a bug. Would you like to open a PR to fix it?

@akichim21
Copy link
Author

I tried to respond, but could not take the time to respond to the CI.
#2182

I have addressed this with PATCH, but I hope it will be addressed on the library side.

When the server error occurred, the client would make multiple connections and the DISCONNECT did not occur immediately.
The server stopped working due to the large number of connections.

@dplewis
Copy link
Member

dplewis commented Jun 23, 2024

Thanks for the feedback. Thats a major issue, i'll see if I can write a test for it.

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Jun 23, 2024
@dplewis
Copy link
Member

dplewis commented Jun 23, 2024

@akichim21 I opened a PR for this #2184 if you want to check it out.

@akichim21
Copy link
Author

Thank you for your response.
I check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
3 participants