fix: LiveQueryClient.resubscribe with Parse Server 7 causes many open connections
#2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2184 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6364 6365 +1
Branches 1535 1506 -29
=========================================
+ Hits 6364 6365 +1 ☔ View full report in Codecov by Sentry. |
mtrezza
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Looks good; @akichim21 do you want to try this out before we merge, to see whether it solves the reported bug?
mtrezza
changed the title
keys and watch to LiveQueryClient.resubscribeLiveQueryClient.resubscribe with Parse Server 7 causes many open connections
|
@dplewis changed PR title to describe the issue; is the new title ok? |
|
The title is perfect! |
mtrezza
approved these changes
Jun 24, 2024
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 24, 2024
# [5.2.0-alpha.3](5.2.0-alpha.2...5.2.0-alpha.3) (2024-06-24) ### Bug Fixes * `LiveQueryClient.resubscribe` with Parse Server 7 causes many open connections ([#2184](#2184)) ([71b4d17](71b4d17))
|
🎉 This change has been released in version 5.2.0-alpha.3 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 24, 2024
# [5.2.0-beta.1](5.1.0...5.2.0-beta.1) (2024-06-24) ### Bug Fixes * `LiveQueryClient.resubscribe` with Parse Server 7 causes many open connections ([#2184](#2184)) ([71b4d17](71b4d17)) * `Parse.Installation` not working when installation is deleted on server ([#2126](#2126)) ([22360b4](22360b4)) * Duplicate pending operations on nested fields ([#2162](#2162)) ([df6df7c](df6df7c)) ### Features * Support dot notation on array fields ([#2120](#2120)) ([25ec684](25ec684))
|
🎉 This change has been released in version 5.2.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 29, 2024
# [5.2.0](5.1.0...5.2.0) (2024-06-29) ### Bug Fixes * `LiveQueryClient.resubscribe` with Parse Server 7 causes many open connections ([#2184](#2184)) ([71b4d17](71b4d17)) * `Parse.Installation` not working when installation is deleted on server ([#2126](#2126)) ([22360b4](22360b4)) * Dot notation on JSON arrays doesn't work on `PushStatus` offset fields ([#2194](#2194)) ([e0eb6f0](e0eb6f0)) * Duplicate pending operations on nested fields ([#2162](#2162)) ([df6df7c](df6df7c)) ### Features * Support dot notation on array fields ([#2120](#2120)) ([25ec684](25ec684))
|
🎉 This change has been released in version 5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
The
fieldsattribute was changed tokeysin Parse Server 7,watchwas added in version 6. Resubscribing doesn't subscribe to the same query as the initial subscription. It was discovered that resubscribing withfieldson version 7 will caused resubscribing every second which lead to many connections to the server ultimately resulting in a crash.Closes: #2180
Approach
Tasks