Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix EventEmitter undefined on React Native 0.64 #1351

Merged

Conversation

bduyng
Copy link
Contributor

@bduyng bduyng commented Apr 19, 2021

fixes #1335

@davimacedo
Copy link
Member

Thanks for the PR. Could you please check the failing tests?

@bduyng
Copy link
Contributor Author

bduyng commented Apr 20, 2021

@davimacedo seems like React Native tests are passed but I got these errors. Can you help me with this?

1) Parse EventuallyQueue can saveEventually
  - Error: Timeout - Async function did not complete within 20000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)

2) Parse EventuallyQueue can queue destroy then save
  - Error: XMLHttpRequest failed: "Unable to connect to the Parse API"
  - MongoError: server is closed

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1351 (3036989) into master (d71eb33) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3036989 differs from pull request most recent head 52559cf. Consider uploading reports for the commit 52559cf to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          60       60           
  Lines        5920     5920           
  Branches     1346     1346           
=======================================
  Hits         5875     5875           
  Misses         44       44           
  Partials        1        1           
Impacted Files Coverage Δ
src/EventEmitter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71eb33...52559cf. Read the comment docs.

@davimacedo
Copy link
Member

@davimacedo seems like React Native tests are passed but I got these errors. Can you help me with this?

1) Parse EventuallyQueue can saveEventually
  - Error: Timeout - Async function did not complete within 20000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)

2) Parse EventuallyQueue can queue destroy then save
  - Error: XMLHttpRequest failed: "Unable to connect to the Parse API"
  - MongoError: server is closed

It looks the tests were flaky but they are passing now.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 7512f53 into parse-community:master Apr 21, 2021
@dplewis
Copy link
Member

dplewis commented Apr 22, 2021

@JeffGuKang Can you see if this work? Also does this work with versions < 0.64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: undefined is not an object with React Native v0.64 (EventEmitter)
3 participants