-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix EventEmitter undefined on React Native 0.64 #1351
fix EventEmitter undefined on React Native 0.64 #1351
Conversation
Thanks for the PR. Could you please check the failing tests? |
@davimacedo seems like React Native tests are passed but I got these errors. Can you help me with this?
|
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 60 60
Lines 5920 5920
Branches 1346 1346
=======================================
Hits 5875 5875
Misses 44 44
Partials 1 1
Continue to review full report at Codecov.
|
It looks the tests were flaky but they are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@JeffGuKang Can you see if this work? Also does this work with versions < 0.64 |
fixes #1335