fix: Live Query not working on Expo React Native

[dplewis]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

#1999 introduced swappable custom EventEmitters for runtimes that didn't include Node's builtin EventEmitter or React-Native.

Fixed

start.js:39 Uncaught (in promise) TypeError: Class extends value undefined is not a constructor or null
    at node_modules/parse/lib/node/LiveQuerySubscription.js (LiveQuerySubscription.js:100:42)

The LiveQuery modules no longer extends from the EventEmitter (would break if EM doesn't exist) but copies on and emit from the prototype chain in the constructor where EM could exist. RN: Use a Private Property in EventEmitter created a private property in the addListener (copied to on). This breaks RN since we are trying to access a private property from a non-instance class (no longer extends so not an instance of EventEmitter therefore no access)

TypeError: attempted to use private field on non-instance

Closes: #2082, #2081, #1766, #1522

Approach

Instead of inheriting from the EventEmitter just use a wrapper.

This has been tested on

  "dependencies": {
    "@expo/metro-runtime": "3.1.3",
    "@react-native-async-storage/async-storage": "1.21.0",
    "expo": "50.0.15",
    "expo-status-bar": "1.11.1",
    "parse": "5.0.0",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-native": "0.73.6",
    "react-native-get-random-values": "1.11.0",
    "react-native-web": "0.19.6"
  },

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)

[parse-github-assistant]

Thanks for opening this pull request!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72bc9ac) to head (c4d4d24).
Report is 8 commits behind head on alpha.

❗ Current head c4d4d24 differs from pull request most recent head 665911e. Consider uploading reports for the commit 665911e to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##            alpha     #2109      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files          61        64       +3     
  Lines        6185      6196      +11     
  Branches     1499      1500       +1     
===========================================
+ Hits         6184      6196      +12     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dplewis]

@mtrezza This has been tested by @martinpfannemueller #2081 (comment)

[mtrezza]

So this PR can be closed without merging?

[dplewis]

So this PR can be closed without merging?

This can be merged. This PR fixes the issue posted and has been tested by multiple developers using Expo / React-Native

[mtrezza]

If it fixes an issue, could you add a test for the issue?

[dplewis]

@mtrezza I added a test, looks like codecov is broken again.

[mtrezza]

I believe what you are trying to say is that it's too much effort to write a test for it? So we'll merge without test.

Edit: Thanks for adding a test.

[parseplatformorg]

🎉 This change has been released in version 5.1.0-alpha.4

[parseplatformorg]

🎉 This change has been released in version 5.1.0-beta.1

[parseplatformorg]

🎉 This change has been released in version 5.1.0