Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert helper functions to TypeScript #2132

Merged
merged 4 commits into from
May 16, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 16, 2024

Pull Request

Approach

arrayContainsObject.js
canBeSerialized.js
decode.js
encode.js
equals.js
escape.js
isRevocableSession.js
parseDate.js
promiseUtils.js
unique.js
unsavedChildren.js
uuid

Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (28e60ae).
Report is 39 commits behind head on alpha.

❗ Current head 28e60ae differs from pull request most recent head b92d82a. Consider uploading reports for the commit b92d82a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2132    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6327   +141     
  Branches      1499      1508     +9     
==========================================
+ Hits          6186      6327   +141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team May 16, 2024 13:18
@dplewis
Copy link
Member Author

dplewis commented May 16, 2024

@mtrezza Can you update the list here so we can keep track of progress?

@mtrezza
Copy link
Member

mtrezza commented May 16, 2024

Sure, just post there what's to update. Or is it only the list above?

@mtrezza mtrezza mentioned this pull request May 16, 2024
66 tasks
@mtrezza
Copy link
Member

mtrezza commented May 16, 2024

Will merge after checking branch status after release publish.

@dplewis
Copy link
Member Author

dplewis commented May 16, 2024

Just check off the list, some are missing and have already been converted to TS

CoreManager
InstallationController
Parse.js
ParseGeoPoint
ParseInstallation
ParseObject
ParseSession

@mtrezza mtrezza merged commit f673df6 into parse-community:alpha May 16, 2024
8 of 9 checks passed
@dplewis dplewis deleted the helper-ts branch May 16, 2024 16:49
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.1-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 16, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants