-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to secured endpoints throught Authorization header #358
Conversation
Thanks for the PR. I have to requests: first, It will probably be decided by the second question I have: what is the best way to include http basicauth as well? We want to be able to specify both an auth type and an auth token. Taking all of that into account, I'd ask that this be extended into two fields: Then, change the logic in the REST controller to
|
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
- Coverage 84.35% 84.32% -0.04%
==========================================
Files 46 46
Lines 3663 3668 +5
Branches 835 836 +1
==========================================
+ Hits 3090 3093 +3
- Misses 573 575 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 88.83% 88.85% +0.01%
==========================================
Files 53 53
Lines 4620 4628 +8
Branches 1069 1070 +1
==========================================
+ Hits 4104 4112 +8
Misses 516 516
Continue to review full report at Codecov.
|
This is a change I made to allow communication with a server that require authorization.