-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDS: Improve pinning unsaved objects #795
Conversation
Closes: #792 Saves _localId into the LocalDatastore to keep consistency when querying.
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 92.01% 92.02% +0.01%
==========================================
Files 54 54
Lines 4910 4917 +7
Branches 1088 1091 +3
==========================================
+ Hits 4518 4525 +7
Misses 392 392
Continue to review full report at Codecov.
|
@acinader This PR allows you to updated pinned objects that aren't saved. We find unsaved object by _localId. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me.
package-lock.json is dirty? can you revert?
This reverts commit 379935a.
Closes: #792
Saves
_localId
into the LocalDatastore to keep consistency when querying.