Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDS: Improve pinning unsaved objects #795

Merged
merged 8 commits into from
Apr 23, 2019
Merged

LDS: Improve pinning unsaved objects #795

merged 8 commits into from
Apr 23, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 13, 2019

Closes: #792

Saves _localId into the LocalDatastore to keep consistency when querying.

Closes: #792

Saves _localId into the LocalDatastore to keep consistency when querying.
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #795 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   92.01%   92.02%   +0.01%     
==========================================
  Files          54       54              
  Lines        4910     4917       +7     
  Branches     1088     1091       +3     
==========================================
+ Hits         4518     4525       +7     
  Misses        392      392
Impacted Files Coverage Δ
src/ParseQuery.js 96.04% <100%> (+0.01%) ⬆️
src/LocalDatastore.js 98.69% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cead2c...c0eefba. Read the comment docs.

@dplewis dplewis requested a review from acinader April 13, 2019 19:13
@dplewis
Copy link
Member Author

dplewis commented Apr 18, 2019

@acinader This PR allows you to updated pinned objects that aren't saved. We find unsaved object by _localId.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

package-lock.json is dirty? can you revert?

@dplewis
Copy link
Member Author

dplewis commented Apr 23, 2019

@acinader It I revert package-lock.json the tests fail travis-ci

Edit: I'll create a separate PR for the package-lock.json

@dplewis dplewis merged commit 0865484 into master Apr 23, 2019
@dplewis dplewis deleted the lds-pin-fix branch April 23, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object from Parse in LocalDatastore with the local id doesn't update when I execute the pin function again
2 participants