Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleteIndex and deleteField in ParseSchema #949

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Fix deleteIndex and deleteField in ParseSchema #949

merged 2 commits into from
Oct 10, 2019

Conversation

JeffGuKang
Copy link
Contributor

@JeffGuKang JeffGuKang commented Oct 10, 2019 •
edited
Loading

  • Fix wrong annotations
  • Add return this

@codecov
Copy link

codecov bot commented Oct 10, 2019 •
edited
Loading

Codecov Report

Merging #949 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   91.95%   91.95%   +<.01%     
==========================================
  Files          54       54              
  Lines        5045     5047       +2     
  Branches     1133     1133              
==========================================
+ Hits         4639     4641       +2     
  Misses        406      406
Impacted Files Coverage Δ
src/ParseSchema.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e5bd2...2a7d690. Read the comment docs.

dplewis
dplewis approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis merged commit 1e3bb91 into parse-community:master Oct 10, 2019
@rabidaudio rabidaudio mentioned this pull request Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplewis dplewis dplewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffGuKang @dplewis