-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Parse.File getData cancel #951
Conversation
Allow to cancel downloading file data or uploading via uri (uri is first downloaded to base64 then uploaded to the server)
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
==========================================
- Coverage 91.94% 91.92% -0.03%
==========================================
Files 54 54
Lines 5064 5076 +12
Branches 1137 1139 +2
==========================================
+ Hits 4656 4666 +10
- Misses 408 410 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. I have a question about how you're handling and keeping track of abort.
@acinader I have made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. this is cool.
Thanks for reviewing! |
Allow to cancel downloading file data or uploading via uri (uri is first downloaded to base64 then uploaded to the server).