Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Parse.File getData cancel #951

Merged
merged 8 commits into from
Oct 15, 2019
Merged

Support Parse.File getData cancel #951

merged 8 commits into from
Oct 15, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 12, 2019

Allow to cancel downloading file data or uploading via uri (uri is first downloaded to base64 then uploaded to the server).

Allow to cancel downloading file data or uploading via uri (uri is first downloaded to base64 then uploaded to the server)
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #951 into master will decrease coverage by 0.02%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   91.94%   91.92%   -0.03%     
==========================================
  Files          54       54              
  Lines        5064     5076      +12     
  Branches     1137     1139       +2     
==========================================
+ Hits         4656     4666      +10     
- Misses        408      410       +2
Impacted Files Coverage Δ
src/ParseFile.js 96.17% <89.47%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc26b15...e08083f. Read the comment docs.

dplewis added a commit that referenced this pull request Oct 14, 2019
@dplewis dplewis mentioned this pull request Oct 14, 2019
@dplewis dplewis requested a review from TomWFox October 15, 2019 15:10
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. I have a question about how you're handling and keeping track of abort.

src/ParseFile.js Outdated Show resolved Hide resolved
src/ParseFile.js Outdated Show resolved Hide resolved
src/ParseFile.js Show resolved Hide resolved
@dplewis
Copy link
Member Author

dplewis commented Oct 15, 2019

@acinader I have made the requested changes

src/ParseFile.js Outdated Show resolved Hide resolved
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. this is cool.

@dplewis
Copy link
Member Author

dplewis commented Oct 15, 2019

Thanks for reviewing!

@dplewis dplewis merged commit 892636c into master Oct 15, 2019
@dplewis dplewis deleted the getData-cancel branch October 15, 2019 18:42
dplewis added a commit that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants