Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate installationId as UUID #972

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Generate installationId as UUID #972

merged 1 commit into from
Oct 28, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 28, 2019

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #972 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files          54       54              
  Lines        5078     5075       -3     
  Branches     1142     1142              
==========================================
- Hits         4664     4661       -3     
  Misses        414      414
Impacted Files Coverage Δ
src/InstallationController.js 90% <100%> (-1.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3d6e6...0b00708. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@dplewis dplewis merged commit 450bbf7 into master Oct 28, 2019
@dplewis dplewis deleted the installationUUID branch October 28, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants