Allow Parse SDK to be built for maccatalyst #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mman Is this change to allow consumer apps to build with Parse as a dependency? Does the build fail without this? I haven't used Catalyst, but I had understood that it was mostly a technology affecting user-facing interfaces. So I expected consumer apps to check that box, but include Parse as a library. |
|
@drdaz Yes, without this change the build for catalyst with Parse.xcodeproj included as a subproject fails. With this change the build passes correctly. Not sure why this is needed at all, but I assume some projects simply do not support catalyst and therefore do not advertise its support. Parse and Bolts nowadays compiles just fine with this change. |
Merged
drdaz
previously approved these changes
Oct 11, 2020
drdaz
approved these changes
Oct 12, 2020
drdaz
added a commit
that referenced
this pull request
Oct 14, 2020
* Updates version numbers * Updates changelog * Apple user details (#1551) * Adds callback to PFLoginViewController for received Apple credentials object * Adds user to Apple credential callback * Fixes target membership * Cleans up target membership * Removes CCI Carthage build dependency on iOS. iOS tests are still temperamental. * Removes @import * Allow Parse SDK to be built for maccatalyst (#1543) * allow Parse SDK to be built for maccatalyst * Updates version numbers * Updates changelog * changed minimumosversion to 8.0 (#1521) * changed minimumosversion to 8.0 closes #1515 * Updates version numbers * Updates changelog * Update changelog * nits Co-authored-by: Martin Man <mman@martinman.net> Co-authored-by: Manuel <trezza.m@gmail.com> Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to build Parse SDK for maccatalyst by "checking the box".