Cleanup assertions, convert to macros where possible. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| format:@"A role's name can only contain alphanumeric characters, _, -, and spaces."]; | ||
| } | ||
| if ([key isEqualToString:@keypath(PFRole, name)]) { | ||
| PFConsistencyAssert(self.objectId, @"A role's name can only be set before it has been saved."); |
|
Too much boolean logic for a friday evening :) |
nlutsenko
force-pushed
the
nlutsenko.assertions
branch
from
b167a9f
to
684bd62
Compare
|
Too much indeed... |
nlutsenko
force-pushed
the
nlutsenko.assertions
branch
from
684bd62
to
0856ed3
Compare
nlutsenko
added a commit
that referenced
this pull request
Aug 17, 2015
Cleanup assertions, convert to macros where possible.
This was referenced Apr 13, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved many places where we do weird assertions, or where we use a condition but could have used a macro. Also fixed some typos.
Improves the bigger enhancement request in #6