Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ParseFacebook accept expiresIn parameter #104

Merged
merged 4 commits into from
Mar 28, 2021
Merged

Let ParseFacebook accept expiresIn parameter #104

merged 4 commits into from
Mar 28, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 28, 2021

  • Switch the expirationDate to expiresIn and allow it to accept an Int value instead of a Date.
  • Fixed bug that prevented limited login from working.
  • Let expiresIn be optional since developers using the Facebook SDK won't need it. The optional parameter may be needed for Swift Linux, Android, etc. who don't have a Facebook SDK.

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #104 (4b28303) into main (a233682) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4b28303 differs from pull request most recent head b989915. Consider uploading reports for the commit b989915 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   81.01%   81.02%   +0.01%     
==========================================
  Files          65       65              
  Lines        5474     5477       +3     
==========================================
+ Hits         4435     4438       +3     
  Misses       1039     1039              
Impacted Files Coverage Δ
...Swift/Authentication/3rd Party/ParseFacebook.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a233682...b989915. Read the comment docs.

@cbaker6 cbaker6 merged commit f3f2244 into main Mar 28, 2021
@cbaker6 cbaker6 deleted the facebook branch March 28, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant