Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix throwing error when linking auth types due to missing sessionToken #109

Merged
merged 1 commit into from Apr 2, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 2, 2021

There was an issue when linking authTypes occurred and an error would be thrown because the sessionToken was missing. The fix is to account for when the server sends/doesn't send a sessionToken. Fix #108

  • fixed issue
  • adjusted testcases
  • added changelog entry
  • prepare for version release

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #109 (073b8b0) into main (f3f2244) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 073b8b0 differs from pull request most recent head 1697468. Consider uploading reports for the commit 1697468 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   81.02%   81.05%   +0.02%     
==========================================
  Files          65       65              
  Lines        5477     5479       +2     
==========================================
+ Hits         4438     4441       +3     
+ Misses       1039     1038       -1     
Impacted Files Coverage Δ
Sources/ParseSwift/API/Responses.swift 88.57% <ø> (ø)
...Authentication/Protocols/ParseAuthentication.swift 74.43% <100.00%> (+0.39%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 81.37% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f2244...1697468. Read the comment docs.

@cbaker6 cbaker6 closed this Apr 2, 2021
@cbaker6 cbaker6 reopened this Apr 2, 2021
@cbaker6 cbaker6 merged commit 7024222 into main Apr 2, 2021
@cbaker6 cbaker6 deleted the linkSessionToken branch April 2, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse decoding error at ParseAuthentication linkCommand when sessionToken is missing from response
1 participant