Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Correctly save objectId of Installation #116

Merged
merged 16 commits into from Apr 3, 2021
Merged

Bug fix: Correctly save objectId of Installation #116

merged 16 commits into from Apr 3, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 3, 2021

ParseInstallation is slightly different than other ParseObjects as it's created with a unique identifier (installationId) locally on the device and may or may not be saved depending on the app use case. This fixes a bug for when the Installation is saved to the server and the objectId of the Installation wasn't saved to the Keychain. This prevents the ability to fetch an updated Installation because fetch is based on the objectId.

Fix #115 Should also fix multiple save issue mentioned in #93

  • Use installationId's when comparing objectIds to update the keychain
  • Update testcases
  • Fixed bugs with deleteAll for ParseInstallation and ParseUser
  • Added changelog entry

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #116 (350ed14) into main (f4ee1b9) will decrease coverage by 0.29%.
The diff coverage is 65.33%.

❗ Current head 350ed14 differs from pull request most recent head 304be67. Consider uploading reports for the commit 304be67 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   80.95%   80.66%   -0.30%     
==========================================
  Files          65       65              
  Lines        5461     5498      +37     
==========================================
+ Hits         4421     4435      +14     
- Misses       1040     1063      +23     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseConfig.swift 95.77% <ø> (+1.25%) ⬆️
Sources/ParseSwift/Objects/ParseInstallation.swift 78.46% <55.17%> (-4.09%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 81.56% <100.00%> (+0.34%) ⬆️
Sources/ParseSwift/Parse.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Storage/KeychainStore.swift 97.75% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 76.77% <0.00%> (ø)
...t/LiveQuery/Protocols/ParseLiveQueryDelegate.swift 20.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ee1b9...304be67. Read the comment docs.

@cbaker6 cbaker6 merged commit be5de49 into main Apr 3, 2021
@cbaker6 cbaker6 deleted the current branch April 3, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParseInstallation does not store object ID in key-value store
1 participant