Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emailVerified to ParseUser #129

Merged
merged 13 commits into from
Apr 26, 2021
Merged

Add emailVerified to ParseUser #129

merged 13 commits into from
Apr 26, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 25, 2021

Notable improvements:

  • Add emailVerified to ParseUser. The emailVerified key is skipped during encoding as this value can't be changed from the client.
  • Improve relative query by taking QueryConstraint as an argument.

Add missing docs:

  • Order enum for query
  • Access enum for ACL
  • ParseEncoder docs
  • General operator query constraints
  • Modified ParseSwift.initialize in readme to simplest form. Developers can look at API docs if they want to do a more sophisticated initialization such as adding a different live query server or using certificate pinning.

In addition:

  • Add entry to changelog
  • Prepare for release

Missing docs...
@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #129 (3cd4caa) into main (99b6196) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   81.38%   81.37%   -0.02%     
==========================================
  Files          65       65              
  Lines        5706     5708       +2     
==========================================
+ Hits         4644     4645       +1     
- Misses       1062     1063       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/Coding/ParseCoding.swift 89.36% <ø> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 81.52% <ø> (-0.16%) ⬇️
Sources/ParseSwift/Protocols/Objectable.swift 87.50% <ø> (ø)
Sources/ParseSwift/Types/ParseACL.swift 86.09% <ø> (ø)
Sources/ParseSwift/Types/Query.swift 91.48% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b6196...3cd4caa. Read the comment docs.

@cbaker6 cbaker6 changed the title Add docs to Order enum Add missing documentation Apr 25, 2021
@cbaker6 cbaker6 requested a review from TomWFox April 26, 2021 04:28
@cbaker6 cbaker6 changed the title Add missing documentation Add emailVerified to ParseUser Apr 26, 2021
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@cbaker6 cbaker6 merged commit 13c2a04 into main Apr 26, 2021
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch April 26, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants