Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom objectId fetch #139

Merged
merged 5 commits into from
May 11, 2021
Merged

Fix custom objectId fetch #139

merged 5 commits into from
May 11, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 11, 2021

Fixes issue where Swift SDK prevents fetching of Parse objects when custom objectId is enabled. This is due to checking for createdAt for a saved object. Close #138

  • Only check objectId for fetchCommand
  • Add testcase
  • Add playground example
  • Add changelog

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #139 (02eca1e) into main (50935e0) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 02eca1e differs from pull request most recent head 45ce440. Consider uploading reports for the commit 45ce440 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   80.86%   80.70%   -0.16%     
==========================================
  Files          68       68              
  Lines        6345     6345              
==========================================
- Hits         5131     5121      -10     
- Misses       1214     1224      +10     
Impacted Files Coverage Δ
Sources/ParseSwift/API/API+Commands.swift 78.04% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 78.62% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 81.67% <100.00%> (+0.15%) ⬆️
Sources/ParseSwift/Protocols/Objectable.swift 87.50% <100.00%> (ø)
Sources/ParseSwift/Internal/Data+hexString.swift 68.96% <0.00%> (-31.04%) ⬇️
Sources/ParseSwift/Storage/ParseFileManager.swift 89.31% <0.00%> (-0.77%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 77.00% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50935e0...45ce440. Read the comment docs.

@cbaker6 cbaker6 merged commit a8b3d00 into main May 11, 2021
@cbaker6 cbaker6 deleted the customObjectIdFetch branch May 11, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.fetch() with custom objectId
1 participant