Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future proof SDK by always sending clientVersion header #146

Merged
merged 2 commits into from
May 18, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 17, 2021

These changes will proof the SDK by making it easier for future additions.

  • Always send clientVersion header with all API calls. This allows the server to handle different versions of the client SDK in particular ways
  • Add PATCH to API for future use
  • Fix context playground example
  • Test changes in playground with real server to ensure everything still works
  • Add entry to changelog

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #146 (aab6eec) into main (608a69f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   81.51%   81.52%           
=======================================
  Files          68       68           
  Lines        6384     6387    +3     
=======================================
+ Hits         5204     5207    +3     
  Misses       1180     1180           
Impacted Files Coverage Δ
Sources/ParseSwift/API/API+Commands.swift 79.55% <100.00%> (ø)
Sources/ParseSwift/API/API.swift 98.23% <100.00%> (+0.04%) ⬆️
Sources/ParseSwift/Objects/ParseInstallation.swift 78.62% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 77.00% <0.00%> (-0.54%) ⬇️
Sources/ParseSwift/Coding/ParseEncoder.swift 75.16% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608a69f...aab6eec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant