Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append instead of replace when using query #155

Merged
merged 2 commits into from
Jun 5, 2021
Merged

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 5, 2021

Allow appending of select, exclude, include, and fields

  • Add test cases
  • Add changelog

@cbaker6 cbaker6 closed this Jun 5, 2021
@cbaker6 cbaker6 reopened this Jun 5, 2021
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #155 (1639377) into main (685f07a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   81.98%   82.06%   +0.08%     
==========================================
  Files          70       70              
  Lines        6555     6579      +24     
==========================================
+ Hits         5374     5399      +25     
+ Misses       1181     1180       -1     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/Messages.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/Query.swift 93.17% <100.00%> (+0.87%) ⬆️
Sources/ParseSwift/Coding/AnyEncodable.swift 61.18% <0.00%> (-0.66%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 77.00% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685f07a...1639377. Read the comment docs.

@cbaker6 cbaker6 merged commit b064000 into main Jun 5, 2021
@cbaker6 cbaker6 deleted the improveSelectExclude branch June 5, 2021 16:11
@dplewis
Copy link
Member

dplewis commented Jun 5, 2021

Can you teach me swift? Lol

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jun 5, 2021

Anytime you are ready, your JS skills should transfer over seamlessly to Swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants